kubernetes-sigs / external-dns / 33723371623
82%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 158
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.677% (+0.09%) from 81.588%
33723371623

push

github

web-flow 
feat(cloudflare): support TLSA records (#6616)

* feat(cloudflare): support TLSA records

Cloudflare models TLSA as discrete data fields rather than a content
string, and rejects a content-only request with "usage is a required data
field". Build TLSA writes from data across all four paths: individual
create and update, batch post and batch put. This follows the existing
SRV handling, which solves the same problem.

Normalise the certificate association data to lowercase hex without
separators on both read and write. Cloudflare renders it uppercase and
whitespace-separated, so without this a record would never compare equal
to itself and every sync would issue a redundant update.

Also allow TLSA to be read back, which the planner needs to see existing
records, force proxying off since Cloudflare cannot proxy TLSA, and add
TLSA to the registry's supported records so ownership TXT names map back
to a record type. Without the last one an ownership record is written but
never recognised again, leaving it orphaned in the zone.

Add a TLSA case to the fake source, since it generates an endpoint for
every entry in KnownRecordTypes and errors on types it cannot build.

Signed-off-by: Oscar Wieman <oscar@oscarr.nl>

* Condense comments

* fix(cloudflare): warn when TLSA content cannot be parsed

The verbatim fallback leaves the digest unnormalised, so every sync
updates. Also reorders the supported-records list alphabetically.

Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

---------

Signed-off-by: Oscar Wieman <oscar@oscarr.nl>
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>

15557 of 19047 relevant lines covered (81.68%)

1105.53 hits per line

Coverage Regressions

Lines Coverage ∆ File
13
96.26
 0.56% cloudflare/cloudflare_batch.go
12
92.82
 0.03% cloudflare/cloudflare.go
2
95.0
 0.13% fake.go
Jobs
ID Job ID Ran Files Coverage
1 run-macos-latest - 33723371623.1 158
81.68
 GitHub Action Run
2 run-ubuntu-latest - 33723371623.2 158
81.68
 GitHub Action Run
Source Files on build 33723371623