oracle / karpenter-provider-oci / 33695801306

80%

Build Type

push

github

Committed by web-flow

Commit Message

fix: correct eviction threshold memory units and hard/soft field reads (#75)

evictionThreshold() built its memory base as int64(gbs*1024*1024) and
passed it to resource.NewQuantity, which takes bytes. gbs is in GiB, so
the conversion needs 1024^3; every percentage-based memory threshold came
out 1024x too small.

Since the eviction threshold is part of InstanceTypeOverhead, and core
computes allocatable as capacity minus that overhead, this over-estimated
allocatable memory by nearly the whole intended threshold -- ~3.2 GiB on a
32 GiB node with memory.available: 10%. Karpenter then launches a node the
pending pod cannot fit on and, with no feedback loop, repeats indefinitely.

Separately, both the hard and soft blocks read EvictionHard for memory and
EvictionSoft for nodefs, so EvictionSoft[memory.available] and
EvictionHard[nodefs.available] were never consulted, and a KubeletConfig
setting only evictionSoft produced no threshold at all.

Only configs using percentage-valued memory signals are affected; absolute
values such as 500Mi are parsed directly and were always correct.

Two existing cases in TestEvictionThreshold asserted the buggy values (with
a comment reading '32Mi * 0.1' for a 32 GiB node) and are updated.

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

5088 of 6375 relevant lines covered (79.81%)

0.92 hits per line