lpenz / omnilint / 33692426493

89%

main: 89%

Build Type

push

github

Committed by lpenz

Commit Message

refactor: replace per-linter boilerplate with shared CommandLinter

Every external-tool linter duplicated the same plumbing: a struct holding a
PathBuf and a Linter, a new() that constructed a Command, spawned the process
and stored it, and a manual Stream impl whose poll_next delegated to a shared
free function. This was verbose, error-prone, and scattered the common logic
across 37 nearly-identical files.

Introduce a single data-driven implementation in src/linters/mod.rs:

- Spec: a small descriptor (linter name, static args, optional dynamic
  extra_args, whether findings are on stderr, how to resolve the executable,
  and a line->Vec<Entry> parser). Defaults cover the common cases so each
  linter only overrides what it needs.
- Executable: picks between looking the binary up by the linter's own name
  (Named) or via executable_for_linter (Mapped), used by go-vet and py_compile.
- CommandLinter: owns the spawned Linter plus a per-line parse fn and a
  VecDeque that buffers the multiple entries a single output line may yield
  (needed by eslint/mypy). It replaces the old free poll_next while preserving
  the "linter not found" single-entry behavior and stderr/stdout selection.
- into_entries: adapts the single-finding parse_line -> Option<Entry> helpers
  used by most custom linters to the new Vec-returning parser signature.
- linter_stream!: a macro that emits the delegating Stream impl for each thin
  wrapper struct, so linter modules no longer hand-write any stream code.

Each linter module is reduced to a new() that builds a Spec plus a parse
function; the custom parse_line logic and its unit tests are unchanged.
parse_line_standard now returns Vec<Entry> and fits the new parser signature
directly.

Net result: 887 insertions, 1470 deletions. All checks pass (cargo fmt,
cargo clippy, cargo test, test-nix.sh).

Coverage Stats

372 of 527 new or added lines in 38 files covered. (70.59%)

8 existing lines in 8 files now uncovered.

2547 of 2859 relevant lines covered (89.09%)

10.77 hits per line