Qiskit / qiskit / 33685284928

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Add Rust native Store instruction (#16897)

* Add Rust native Store instruction

This commit adds a Rust native representation of the store instruction.
While the instruction logically fits under the StandardInstruction type
it is added a as a new variant on the PackedOperation struct because
it is too wide to fit in the StandardInstruction data on PackedOperation
which is limited. The store type needs to contain two Expr objects so
that requires a layer of pointer indirection to fit in PackedOperation.
We need to do the bit packing for pointer types on PackedOperation which
precludes using it in StandardInstruction.

This commit adds the data model support for the store instruction to
Rust. It doesn't move any of the UI around interacting with or creating the
Store instructions to Rust. For example, the input type checking still when
creating a new instruction that validates the lhs is a l-value and the
rhs is a valid type only exists in Python as of this commit. The goal of
this PR was to move the source of truth for the data to Rust not to
provide an interface for it to Rust. As this is sufficient to remove the
python data dependency from CircuitData and DAGCircuit around dealing
with store instructions.

This also does not include C support for the instruction that will be a
future PR.

Fixes #16895

* Add docstrings and rename lhs/rhs to lvalue/rvalue

* Use static for store class name str in qpy circuit writer

* Avoid python for qpy deserialization of Store

This commit fixes an oversight in earlier commits on the PR. Previously
the PR only updated the QPY serialization to use the rust store struct
directly instead of going through Python. This was forced by the data
model because the QPY circuit writer needed to handle the new enum
variants in the serialization. But on the deserialization side it was
overlooked and the qpy deserializer would go through python issue to
create the store object and the extract the rust struct from that.
This simp... (continued)

Coverage Stats

112 of 138 new or added lines in 14 files covered. (81.16%)

24 existing lines in 6 files now uncovered.

115798 of 131891 relevant lines covered (87.8%)

985462.46 hits per line