microlinkhq / youtube-dl-exec / 33679330477

96%

push

github

fix: spawn yt-dlp without a shell (#283)

* fix: spawn yt-dlp without a shell

PR #270 set shell:true on Windows when the binary path
had a space. spawn does not escape args in that mode, so
user-controlled URLs and flags were interpreted by cmd.exe.

Pass the file path to spawn intact instead.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: wait for spawn close and run fixture via node

Resolve the subprocess on close so stdout/stderr are
complete. Point the regression test at a real node
binary in a spaced path so it works on Windows.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor: clarify the no-shell spawn wrapper

Extract error construction and drop the dead trim/&& collect
tricks so the file-path spawn is easier to follow.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor: drop inlined spawn for tinyspawn 1.5.10

Array form keeps the binary path intact, so the local
wrapper and the #270 shell:true workaround can go.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: omit empty url from tinyspawn argv

1.5.10 keeps empty strings. yt-dlp then exits 1
instead of the no-url usage code 2.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

26 of 30 branches covered (86.67%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

139 of 141 relevant lines covered (98.58%)

5.48 hits per line