kubevirt / containerized-data-importer / #6226

50%

push

travis-ci

  datavolume: emit event when PVC size is raised to the minimum supported size (#4255)

Storage profiles for certain provisioners (e.g. AWS io2, GCP
  sp-balanced-storage) carry a cdi.kubevirt.io/minimumSupportedPvcSize
  annotation. When a user requests a DataVolume/PVC smaller than that
  minimum, CDI silently grows the request to the minimum, which is
  confusing: the created PVC is larger than what was asked for.

  Emit a Normal "MinimumPVCSizeApplied" event on the DataVolume whenever
  the requested size is bumped up to the storage profile's minimum, so the
  user can see, via `kubectl describe dv`, why the PVC size differs from
  their request.

  renderPvcSpecVolumeSize reports whether the minimum was applied via a
  renderResult struct, keeping the size computation free of event
  infrastructure. pvcFromStorage, which holds the recorder and the
  DataVolume, emits the event based on that result. The comparison is made
  only around the minimum-size step, so filesystem overhead inflation never
  triggers the event. The PVC mutating webhook path is unaffected.

Signed-off-by: Ady Cohen <adcohen@redhat.com>

18 of 20 new or added lines in 1 file covered. (90.0%)

15183 of 30518 relevant lines covered (49.75%)

0.56 hits per line