decentraland / builder / 33674668662

53%

master: 57%

Build Type

Pull #3473

github

Committed by web-flow

Commit Message

refactor: take the latest marketplace from decentraland-dapps

getLatestOffchainSale repeated dapps' candidate order, so two lists had to stay in
step by hand. They agree on every chain today, but this PR already shipped one bug
from exactly that kind of drift, and the next marketplace version is when it bites.

Builder keeps its own list for a different question: every version a collection might
still hold minter rights on, including V1, which the revoke path needs and dapps has
no reason to know about.

Also drops the resolver-comparison test. With the delegation it compares a value to
itself, and a test that cannot fail reads as coverage without being any. The domain
assertion stays and still catches a divergent signer - verified.

Pull Request Pull Request #3473: feat: list collections through the newest off-chain marketplace

Coverage Stats

2621 of 5998 branches covered (43.7%)

Branch coverage included in aggregate %.

12 of 21 new or added lines in 3 files covered. (57.14%)

71 existing lines in 2 files now uncovered.

7793 of 13375 relevant lines covered (58.27%)

37.36 hits per line