raystack / frontier / 33670678790

50%

main: 49%

Pull #1913

github

feat(consent): add app.consent config, the consent service, and ListConsentDocuments

Config is the source of truth for what a deployment asks people to accept,
and an endpoint is how a client learns it. No database, no writes, and
frontier never reads a document or parses a version string.

app.consent is a map keyed by document id, beside app.authentication and
app.pat. A map because it matches authenticate.Config keying oidc_config by
strategy name, the key enforces unique ids, and a single field stays
env-overridable. Every document in it is required at signup, so there is no
per-document required flag: an optional document would need withdrawal,
which is out of scope.

Boot validation rejects empty ids, titles, versions and URLs, URLs that do
not parse or that a client cannot link to, and an enabled block with no
documents, which would otherwise look identical to a working deployment
while asking nobody to accept anything. The title is required alongside the
rest because it is the label a client puts on the link, so a document
without one asks the user to accept a bare url. The resolved set is logged
at boot, because an env override cannot alter an existing record but it can
produce wrong new ones, and that log rather than the config repo is what
says what a deployment was serving.

The service owns the config, so it owns the checks. Documents orders by id.
Resolve maps ids to their config snapshots and rejects ids config does not
know, saying nothing about completeness. ResolveAll adds the completeness
rule and compares both sets in both directions, so the error names what is
wrong. Disabled, all three are empty and no id is rejected, so one client
build works against both kinds of deployment.

ListConsentDocuments mirrors ListAuthStrategies and is unauthenticated on
purpose: the URLs are meant to be read by anyone considering an account, and
the ids are an input to an unauthenticated Authenticate, so requiring a
session to learn what to accept ... (continued)

121 of 144 new or added lines in 5 files covered. (84.03%)

20278 of 40772 relevant lines covered (49.74%)

15.92 hits per line