decentraland / builder-server / 33644299866

72%

master: 72%

Build Type

Pull #811

github

Committed by cyaiox

Commit Message

fix: require authentication on GET /thirdParties/:id and simplify resolution

- Require authentication on GET /thirdParties/:id (strict), removing the
  unauthenticated surface. Unpublished records return 404 to non-managers;
  indexed records are readable by any authenticated wallet.
- Reuse the already-fetched record in the handler instead of re-resolving the
  managers, removing redundant graph and DB round-trips on that path.
- Simplify isManager with a named approval check and a single fast path.
- Update the OpenAPI docs: GET /thirdParties is scoped to the authenticated
  wallet (no manager param), and GET /thirdParties/:id now requires auth
  (401/404).

Pull Request Pull Request #811: fix: harden third-party manager resolution and read scoping

Coverage Stats

1476 of 2252 branches covered (65.54%)

Branch coverage included in aggregate %.

33 of 38 new or added lines in 5 files covered. (86.84%)

1 existing line in 1 file now uncovered.

3360 of 4425 relevant lines covered (75.93%)

49.79 hits per line