Tatsh / dade / 33642771235

100%

push

github

fix(maxpayne): place Max Payne 2 props on their mesh midpoint and pace their clips

A dynamic mesh writes its vertices about their own midpoint rather than about the state
machine that places it. The vector stating where that midpoint falls was being read as the
third component of the prop's bounding box, so it was dropped and every prop sat offset by
it.

It is not part of the bounding box. X_LevelDynamicMesh::construct @ 100045b0 reads exactly
two M_Vector3 into stack locals and drops them; the third is read by X_LevelMesh::construct
@ 1000abc0, whose first act is `LEA EDX,[ESI + 0x10]` / `CALL dword ptr [0x10011258]` --
the same M_Vector3 operator>> a room uses for its own two -- ahead of the `TEST BL,BL` that
decides whether geometry follows. It lands on the member X_LevelMesh::getMidpoint returns
(`LEA EAX,[ECX + 0x10]`), which X_LevelDynamicMesh::getMeshMidpoint @ 10003ca0 forwards to.

A prop therefore stands at `(vertex + midpoint) * fsm_matrix`, with the midpoint turned by
the matrix, and its clips need the same correction on both transforms. Two independent
measurements fix the direction. 10_Police_Station's vending machine cover states
(0.047, -0.078, 0.112): mapping its UVs through the machine body's own front-plane mapping
puts the panel at y in [-4.29, -3.19], and the recess it closes spans y in [-4.294, -3.200].
Across the twenty-four Game levels, props whose base meets a floor exactly go from 119 of
1671 to 854. A cell door is the clearest case, its state machine being the hinge at the top:
without the midpoint it hangs 1.5 units over a floor at y = -10.

Clips were also paced wrongly. The second game states a time with every curve sample and
rarely spaces them evenly -- 898 of the 2454 curves in the first six levels are uneven --
and the times were being discarded for an even spread. The curve is a Catmull-Rom spline,
not a straight line between samples: T_GraphCurve::construct @ 100025f0 in T_GraphMFC.dll
stores the type at [ESI+0x4]... (continued)

5338 of 5342 branches covered (99.93%)

Branch coverage included in aggregate %.

64 of 69 new or added lines in 2 files covered. (92.75%)

20546 of 20551 relevant lines covered (99.98%)

5.0 hits per line