scikit-hep / iminuit / 33642741471

100%

push

github

fix: accept negative and numpy integer parameter indices (#1159)

:robot: _AI text below_ :robot:

`Minuit._normalize_key` only accepted a Python `int` as a positional
key. A numpy integer fell through to the string branch and gave a
confusing "unknown parameter" error. A negative index passed straight
into the C++ layer and raised a `TypeError`. The out-of-range message
also reported `npar` as the maximum, but the largest valid index is
`npar - 1`.

The method now uses `operator.index`, so numpy integers and other
`SupportsIndex` types work. Negative indices count from the end. The
error message reports the correct maximum.

Split from #1138, part of #1132.

12 of 12 new or added lines in 1 file covered. (100.0%)

3917 of 3932 relevant lines covered (99.62%)

1.0 hits per line