decentraland / builder-server / 33642596023

72%

master: 72%

Build Type

Pull #811

github

Committed by cyaiox

Commit Message

fix: prioritize approved on-chain managers and fail closed on lookup errors

Address review feedback on the third-party manager resolution hardening:

- Prioritize the approved on-chain (indexed) managers over the virtual ones.
  Virtual managers are authoritative only while the third party is still a
  draft, i.e. the indexed record is not yet approved (empty root); a rooted
  on-chain record governs regardless of any lingering virtual record.
- Fail closed in the collection create/upsert path: only create a virtual
  third party after a confirmed NonExistentThirdPartyError, and rethrow
  transient lookup errors so a graph/API failure can no longer create a
  caller-owned record.
- Return 404 instead of 401 when a virtual record is requested by a
  non-manager on GET /thirdParties/:id, so the response is indistinguishable
  from a genuine miss.
- Drop the standalone ManagerContinuity integration spec; its scenarios are
  covered by the collection router tests and the manager-resolution unit
  tests.

Pull Request Pull Request #811: fix: harden third-party manager resolution and read scoping

Coverage Stats

1475 of 2253 branches covered (65.47%)

Branch coverage included in aggregate %.

36 of 41 new or added lines in 5 files covered. (87.8%)

1 existing line in 1 file now uncovered.

3360 of 4426 relevant lines covered (75.92%)

49.75 hits per line