yext / answers-search-ui / 33641310345

62%

push

github

fix: remove autocomplete result count span (#2002)

Removes a span that was used to announce the autocomplete results count, because it was focusable when navigating using the VoiceOver cursor (⌃ + ⌥ on Mac when VoiceOver is enabled, e.g. via ⌘ + F5). The span served two purposes: announce result counts and act as the listbox's accessible label. These concerns are now split up. The autocomplete component uses `document.ariaNotify()` to announce result counts when support by the browser and falls back to a div with role="status" to announce changes for older browsers. A stable listbox label is used for the listbox.

J=TECHOPS-19196
TEST=auto,manual

Added regression tests. Spun up the theme test site while pointing to a locally served SDK bundle with these changes and confirmed the ghost focus is no longer present.

2073 of 3477 branches covered (59.62%)

Branch coverage included in aggregate %.

30 of 31 new or added lines in 1 file covered. (96.77%)

3544 of 5554 relevant lines covered (63.81%)

27.76 hits per line