decentraland / builder-server / 33639961407

72%

master: 72%

Build Type

Pull #811

github

Committed by cyaiox

Commit Message

fix: harden third-party manager resolution and read scoping

Resolve third-party managers virtual-first: while a virtual (draft) record
exists, its managers are authoritative; the indexed on-chain record governs
only once it is the sole record.

- Scope GET /thirdParties to the authenticated wallet instead of a
  client-supplied manager filter.
- Require authentication and manager membership for reads of virtual
  (unpublished) records on GET /thirdParties/:id; keep indexed records public.
- Route the collection create/upsert manager check through the shared
  resolution.
- Match manager addresses case-insensitively across resolution, reads and
  reconciliation via a shared hasManager helper and a case-insensitive
  findByManager query.
- Add unit tests and a ManagerContinuity integration spec covering the
  end-to-end resolution.

Pull Request Pull Request #811: fix: harden third-party manager resolution and read scoping

Coverage Stats

1469 of 2243 branches covered (65.49%)

Branch coverage included in aggregate %.

30 of 34 new or added lines in 5 files covered. (88.24%)

15 existing lines in 3 files now uncovered.

3355 of 4419 relevant lines covered (75.92%)

51.44 hits per line