PHPOffice / PHPPresentation / 33630976787
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 142
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.975%. Remained the same
33630976787

push

github

web-flow 
Address a chart style by the name the document references, not by one the test spells out (#940)

Every assertion about a generated chart style in `ObjectsChartTest` went straight to the
*definition*, by a name spelled out in the test. Nothing looked at the `chart:style-name`
that names it, so a style nothing points at passed.

Measured by replacing every `chart:style-name` the ODPresentation Writer writes with a
literal `BROKEN`, leaving each definition correctly named -- a chart in which no reference
resolves:

    before   58 of 61 tests pass
    after     4 of 61 tests pass

`assertIsSchemaOpenDocumentValid('1.2')` passes on that file too: the OpenDocument
relax-ng does not check that a style reference resolves.

The name is now read from the reference, the way a consumer reads it. One helper resolves
it and nine thin wrappers name the reference: the chart, its title, its legend, its plot
area, an axis by dimension, an axis title, gridlines by class, a series by index and a
data point by index.

`ObjectsChartTest` goes from 794 to 1020 assertions: resolving a name asserts that the
reference node exists and that it carries the attribute.

Nine tests built their XPath before the shape existed, which is harmless with a literal
name and impossible once the helper has to write the presentation to resolve one. Those
statements moved to after the chart is set up.

10903 of 11602 relevant lines covered (93.98%)

72.09 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33630976787.1 142
93.98
 GitHub Action Run
Source Files on build 33630976787