openego / eDisGo / 33605646597

83%

dev: 84%

Build Type

Pull #629

github

Committed by joda9

Commit Message

fix(io): drop the dead bus-to-building-ID map in the PV rooftop import

Cherry-picked from 8105c72a on dev
(branch fix/ego-213-pv-rooftop-building-id-duplicate-bus), without the
changelog entry — this branch has no 0.3.1 section to put it in.

Importing generators failed for some grids with

    ValueError: cannot reindex on an axis with duplicate labels

raised from `gens_df.update()` in `_integrate_pv_rooftop`
(openego/eGo#213, reported for MV grids 33084 and 33695).

The function derived a bus -> building ID map from the conventional loads.
That map was deduplicated on "building_id" but indexed by "bus", so a bus
carrying the loads of two different buildings kept both rows and produced a
duplicated bus label. `gens_df.loc[:, ["bus"]].join(..., on="bus")` then
emitted two rows per generator, and `DataFrame.update` reindexes its argument
onto `self.index`, which rejects a non-unique index.

The map is not repaired here, it is removed, because it has had no effect on
the result for two and a half years. It was introduced in ae002033 to supply
the key for matching existing PV rooftop plants against the scenario data,
which merged `on="building_id"` at the time; the generators in a ding0
topology carry no building ID, so one was guessed from the conventional load
sitting at the same bus. A ToDo above the block already asked for the match
to use the unique MaStR source ID instead. d33e8515 did exactly that and
removed the ToDo, but left the map behind.

Since then the guessed value has been discarded: `gens_existing` is merged
with `pv_rooftop_df` on "source_id" with `suffixes=("_old", "")`, so the
building ID written back to `generators_df` comes from the scenario data and
the guessed one survives only as the unread column `building_id_old`. Every
PV rooftop generator is either decommissioned and removed, or matched and
updated from the scenario, so there is no path on which the guess is read.
Setting the building ID of all 2472 conventional loads in th... (continued)

Pull Request Pull Request #629: Edisgo run edisgo

Coverage Stats

865 of 1143 new or added lines in 30 files covered. (75.68%)

465 existing lines in 13 files now uncovered.

9560 of 11476 relevant lines covered (83.3%)

0.83 hits per line