tamada / oinkie / 33609424881
97%
main: 97%

LAST BUILD BRANCH: releases/v0.4.0
DEFAULT BRANCH: main
Ran
Jobs 1
Files 14
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.64%. Remained the same
33609424881

Pull #76

github

tamada 
fix: check the version argument before writing it anywhere

Review's point, and it holds. The script already failed closed -- a
value carrying the sed delimiter aborted under set -e with every file
untouched -- but it failed as sed's error rather than the script's, and
a missing argument came out as "$1: unbound variable". Neither says what
was wrong.

The argument is now checked before anything is written: exactly one, and
of the shape X.Y.Z after an optional leading v. That is what the release
workflow passes -- it derives it from the branch name releases/vX.Y.Z --
and checking it closes the substitution hole rather than relying on
set -e to catch it afterwards, which matters because this runs on a
release branch where the result is committed and pushed.

The leading v is accepted and stripped rather than rejected, since the
tag form is the one a person would reach for by hand.

Also fixes something I introduced: rewriting through "$file.tmp" left
that file behind when sed failed, for the workflow's `git commit -a` to
pick up. A trap removes it.

Verified across eight inputs. 0.4.0, v0.4.0 and 1.2.3 rewrite; no
argument, 0.4, 0.4.0.1, "0.4.0|s/Tamada/REDACTED/" and "$(touch pwned)"
are refused with the usage message, leave every file untouched, leave no
.tmp behind, and in the last case create nothing. The accepted path is
unchanged: still byte-identical to what #74 wrote by hand, still
idempotent, and the CRID is still 1572824500.3.007232.

Reported by Copilot on #76.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pull Request #76: fix: anchor the version replace to what it is replacing

4487 of 4643 relevant lines covered (96.64%)

32.98 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33609424881.1 14
96.64
 GitHub Action Run
Source Files on build 33609424881