PHPOffice / PHPPresentation / 33608124781

94%

push

github

Shape\Chart\Series : Give the data labels a fill of their own (#963)

A label drawn straight over a chart is read against whatever colour the
slice under it happens to be. PowerPoint answers this with a plate: a
`c:spPr` inside `c:dLbls`, usually white and semi-transparent.

`Series` had no field for it -- `fill`, `dataPointFills`, `font` and
`outline` are all about the slices, not the labels -- and none of the
nine `writeType*` methods wrote a `c:spPr` at all. `getLabelFill()` adds
the field, born of type `Fill::FILL_UNSET` as a fill nobody named is
held everywhere else, and one helper writes the element at all nine of
them, after `c:numFmt` and before `c:txPr` as `CT_DLbls` orders it. The
reader reads it back beside the fill of the serie it already read.

A series that names no label fill writes no `c:spPr`, so nothing changes
for a presentation that never asked. `FILL_NONE` is not the same answer:
it says the labels are to sit on nothing, and writes `a:noFill`.

There is no ODP side to this. ODF 1.2 has no way to say what a data
label sits on: LibreOffice writes `loext:label-fill` and friends, which
the schema rejects, and which loses the transparency on the way out.

Fixes #962

23 of 23 new or added lines in 3 files covered. (100.0%)

10896 of 11595 relevant lines covered (93.97%)

71.69 hits per line