Eyevinn / moqlivemock / 33604451011

53%

main: 53%

Build Type

Pull #139

github

Committed by tobbee

Commit Message

feat(mlmrel): hold a SUBSCRIBE only for the subscriber's RENDEZVOUS_TIMEOUT

Section 10.2.6 of draft-18 puts the wait for a publisher in the subscriber's hands: a SUBSCRIBE carrying RENDEZVOUS_TIMEOUT is held up to that long, the relay may choose less, and a wait that runs out is answered with TIMEOUT; without the parameter the relay MUST answer DOES_NOT_EXIST at once. mlmrel instead held every SUBSCRIBE for an unannounced namespace for a fixed -pending-wait, which contradicted that MUST for the common case. The hold is now the subscriber's RENDEZVOUS_TIMEOUT capped by -max-rendezvous (default 10s), -pending-wait is gone, and the answer code follows the section. The interop entrypoint drops the flag: the runner's subscribe-before-announce clients send no parameter, so they get an immediate DOES_NOT_EXIST, which the case accepts and the section requires. Tests cover a rendezvous that lands inside the wait, one that expires, the relay cap, and the immediate answer without the parameter.

Refs #135

Pull Request Pull Request #139: feat(mlmrel): hold a SUBSCRIBE only for the subscriber's RENDEZVOUS_TIMEOUT

Coverage Stats

16 of 20 new or added lines in 2 files covered. (80.0%)

13 existing lines in 4 files now uncovered.

3090 of 5834 relevant lines covered (52.97%)

1223.27 hits per line