SAP / less-openui5 / 33603622930

95%

master: 95%

push

github

[INTERNAL] Fix theme-caching test broken by fs.Stats lazy getters

deepClone (introduced when the clone dependency was replaced with a
built-in in e3e3083) uses Object.entries, which only captures own
enumerable properties. fs.Stats exposes atime/mtime/ctime/birthtime as
lazy getters that become own properties only once accessed.

The theme cache holds live fs.Stats objects. The second build touches
stat.mtime during its cache-freshness check, materializing mtime on the
shared Stats instance between the two deepClone snapshots, so
cacheFirstRun (before the access) and cacheSecondRun (after) diverged by
exactly that key and the deepEqual failed on every run.

Realize the four date getters inside deepClone before Object.entries, so
the shared Stats is materialized on the first snapshot and every later
snapshot is consistent regardless of access order.

499 of 558 branches covered (89.43%)

Branch coverage included in aggregate %.

915 of 935 relevant lines covered (97.86%)

208.8 hits per line