Logflare / logflare / 33585906010-1

82%

main: 83%

Build Type

Pull #3894

github

Committed by chasers

Commit Message

fix: address PR review on the webhook header inputs

Four fixes from review. Each one reproduced first.

Creating a webhook backend through the UI stored `gzip: false`, against the
documented default of `true`. The form's `for` is a plain map, so
`input_value(f_config, :gzip)` is nil on `:new`. The checkbox rendered
unchecked and its hidden companion submitted "false", so
`default_field_value(:gzip, true)` never fired. The box now renders checked
unless the value is explicitly false. The edit path was already correct.

Renaming a header key dropped its value. The row's value input shows the
REDACTED sentinel, and `unredact_headers/2` looks the replacement up by the
submitted key, so a renamed key matched nothing and the header vanished behind
a success flash. Each row now carries a hidden `header<i>_stored_key`, and
`transform_params/2` resolves the sentinel against that key. Renaming a key
carries its stored value over. The OTLP and Loki header rows submit no
`stored_key`, so their behavior is unchanged.

A batch whose events all fail to encode posted an empty body. The pipeline now
skips the request and logs it, and the formatter middleware returns
`{:error, :all_events_dropped}` rather than sending an empty body from the
Google SecOps path.

The dropped-count log had no backend context, while the JSON path in the same
module already logged `source_id` and `backend_id`. The formatter now takes
metadata, from `encode/2` and from the middleware's `:formatter_opts`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WPMHo5UmWRJnSVJcc36JJW

Pull Request Pull Request #3894: feat: add custom header inputs to the webhook backend form

Coverage Stats

56 of 58 new or added lines in 6 files covered. (96.55%)

2 existing lines in 1 file now uncovered.

14699 of 17878 relevant lines covered (82.22%)

1627.65 hits per line