openconfig / kne / 33564476520

44%

push

github

    This PR improves error handling, certificate idempotency, and command response validation for JunOS / cPTX nodes in KNE.  (#763)

Refine KNE Juniper node error handling, cert idempotency, and response lookup

- Fix RE2 regex matching with isJunosError using multi-line and case-insensitive
  mode `(?im)(\berror:|\bcommit error\b|\bsyntax error\b)`. This prevents false
  positives on configuration keywords/descriptions while capturing all JunOS error
  phrasings.
- Handle 'already exists' output idempotently in waitCertInfraReadyAndPushCert so
  node reuses and pod restarts do not trigger 15-minute retry timeout loops.
- Dynamically locate the response matching the generate-self-signed command to
  avoid premature exit when the preceding key-pair generation returns successfully.
- Fix log variable mismatch in waitConfigInfraReadyAndPushConfigs (use
  configModeRetrySleep instead of certGenRetrySleep).
- Add unit tests in juniper_test.go covering isJunosError regex cases, idempotent
  restarts, and a dedicated testdata fixture for key-success/cert-failure scenarios.

21 of 24 new or added lines in 1 file covered. (87.5%)

5761 of 13226 relevant lines covered (43.56%)

0.49 hits per line