ad2bc1ca-de45-4828-8b65-27415dcf0986
93%
main: 93%

Ran 01 Sep 2026 06:46PM UTC

Jobs 1

Files 127

Run time 1min

Badge

Embed ▾

Committed 01 Sep 2026 06:38PM UTC coverage: 69.444% (-23.7%) from 93.145%

Build # ad2bc1ca-de45-4828-8b65-27415dcf0986

Build Type

Pull #2890

circleci

Committed by

carolyncole

Commit Message

Refactor storage increase request to fetch live Mediaflux quota

Ensure storage capacity emails display the up-to-date capacity by fetching and persisting the live Mediaflux quota before sending the request.

Changes include:
- Add Project#refresh_storage_capacity_from_mediaflux! to query the live Mediaflux quota, parse the allocation string, and update the project's metadata.
- Implement ProjectMetadata#apply_approved_quota to store approved quota size and unit while preserving requested values.
- Update ProjectsController#send_storage_increase_request to call the new refresh method, ensuring the sent email uses the live quota.
- Remove outdated 'validate' pre-commit hook from package.json.
- Add comprehensive spec coverage:
  - Controller specs for #send_storage_increase_request verifying portal JSON refresh and email content.
  - Mailer specs for TigerdataMailer verifying current storage capacity rendering.
  - Model specs verifying quota retrieval, parsing, and error conditions.

Pull Request Pull Request #2890: Refactor storage increase request to fetch live Mediaflux quota

Coverage Stats

0 of 94 branches covered (0.0%)

3 of 19 new or added lines in 3 files covered. (15.79%)

848 existing lines in 76 files now uncovered.

2525 of 3636 relevant lines covered (69.44%)

194.07 hits per line

Uncovered Changes

Lines	Coverage	∆	File
13	70.37	-17.38%	app/models/project.rb
2	61.65	-33.73%	app/models/project_metadata.rb
1	68.5	-16.54%	app/controllers/projects_controller.rb

Coverage Regressions

Lines	Coverage	∆	File
43	61.65	-33.73%	app/models/project_metadata.rb
42	0.0	-93.33%	app/controllers/edit_new_project_request_controller.rb
38	0.0	-95.0%	app/models/mediaflux/project_update_request.rb
38	0.0	-90.48%	app/services/project_import.rb
33	45.0	-55.0%	app/services/princeton_users.rb
30	0.0	-100.0%	app/services/user_error_parser.rb
28	56.98	-32.56%	app/controllers/application_controller.rb
25	0.0	-100.0%	app/services/test_project_generator.rb
21	68.5	-16.54%	app/controllers/projects_controller.rb
21	0.0	-95.45%	app/models/mediaflux/namespace_describe_request.rb
21	0.0	-100.0%	app/models/mediaflux/namespace_list_request.rb
21	85.0	-15.0%	app/models/new_project_request.rb
19	37.5	-47.5%	app/mailers/tigerdata_mailer.rb
18	0.0	-85.71%	app/controllers/users/omniauth_callbacks_controller.rb
18	66.67	-33.33%	app/models/version_footer.rb
18	0.0	-90.0%	lib/xml_utilities.rb
17	0.0	-100.0%	app/models/mediaflux/service_execute_request.rb
17	70.37	-17.38%	app/models/project.rb
16	63.83	-17.02%	app/models/user.rb
15	0.0	-100.0%	app/channels/mediaflux_channel.rb
15	71.67	-25.0%	app/operations/project_create.rb
14	0.0	-100.0%	app/models/mediaflux/asset_exist_request.rb
13	23.81	-61.9%	lib/tasks/xml_schema.rake
12	70.45	-27.27%	app/models/mediaflux/iterator_request.rb
11	0.0	-100.0%	app/controllers/new_project_wizard/additional_information_grants_and_funding_controller.rb
11	0.0	-100.0%	app/controllers/new_project_wizard/additional_information_project_permissions_controller.rb
11	0.0	-100.0%	app/controllers/new_project_wizard/additional_information_related_resources_controller.rb
11	0.0	-100.0%	app/controllers/new_project_wizard/project_information_categories_controller.rb
11	0.0	-100.0%	app/controllers/new_project_wizard/project_information_dates_controller.rb
11	0.0	-100.0%	app/controllers/new_project_wizard/project_type_controller.rb
11	72.92	-22.92%	app/jobs/file_inventory_job.rb
11	0.0	-100.0%	app/models/mediaflux/store_list_request.rb
11	0.0	-68.75%	app/models/mediaflux/time.rb
11	0.0	-100.0%	app/models/project_mediaflux.rb
10	0.0	-100.0%	app/controllers/users/mediaflux_callbacks_controller.rb
9	71.74	-19.57%	app/controllers/new_project_requests_controller.rb
9	0.0	-100.0%	app/controllers/project_import_controller.rb
9	0.0	-100.0%	app/jobs/request_cleanup_job.rb
9	18.18	-81.82%	app/models/mediaflux_status.rb
9	0.0	-100.0%	app/services/test_project_cleaner.rb
8	0.0	-100.0%	app/jobs/file_inventory_cleanup_job.rb
8	86.02	-8.6%	app/models/mediaflux/request.rb
8	50.0	-44.44%	app/models/system_user.rb
8	89.81	-7.41%	app/presenters/project_xml_presenter.rb
7	46.15	-53.85%	app/services/pul_cache.rb
6	0.0	-100.0%	app/models/mediaflux/logout_request.rb
6	0.0	-100.0%	app/models/mediaflux/project_report.rb
6	79.31	-20.69%	app/models/project_validator.rb
6	86.36	-13.64%	app/operations/user_roles_update.rb
5	88.61	-6.33%	app/controllers/request_wizards_controller.rb
5	0.0	-100.0%	app/models/nil_user.rb
4	80.0	-20.0%	app/models/mediaflux/namespace_destroy_request.rb
4	93.33	-6.67%	app/models/mediaflux/project_create_service_request.rb
4	73.33	-26.67%	app/services/pul_datacite.rb
4	63.64	-36.36%	app/services/xml_null_builder.rb
3	75.0	-15.0%	app/models/mediaflux/connection.rb
3	92.31	-7.69%	app/models/mediaflux/logon_request.rb
3	66.67	-33.33%	app/models/mediaflux/version_request.rb
3	78.57	-21.43%	app/services/project_list.rb
2	86.67	-13.33%	app/controllers/welcome_controller.rb
2	0.0	-100.0%	app/lib/tiger_data/ldap_error.rb
2	0.0	-100.0%	app/lib/tiger_data/mailer_error.rb
2	93.02	-4.65%	app/models/mediaflux/asset.rb
2	88.24	-11.76%	app/models/mediaflux/iterator_destroy_request.rb
2	0.0	-100.0%	app/models/mediaflux/session_error.rb
2	0.0	-100.0%	app/models/mediaflux/session_expired.rb
2	77.78	-11.11%	app/models/provenance_event.rb
2	90.48	-9.52%	app/operations/project_search.rb
2	93.1	-6.9%	app/presenters/dashboard_presenter.rb
2	89.47	-5.26%	app/presenters/project_dashboard_presenter.rb
2	86.67	-13.33%	app/services/xml_node_builder.rb
1	92.31	-7.69%	app/controllers/new_project_wizard/project_information_controller.rb
1	92.86	-3.57%	app/helpers/emulator_helper.rb
1	80.0	-20.0%	app/models/file_inventory_request.rb
1	83.33	-8.33%	app/models/inventory_request.rb
1	97.78	-0.56%	app/presenters/project_show_presenter.rb

Jobs

ID	Job ID	Ran	Files	Coverage
1	ad2bc1ca-de45-4828-8b65-27415dcf0986.1	01 Sep 2026 06:46PM UTC	127	69.44

pulibrary / tigerdata-app / ad2bc1ca-de45-4828-8b65-27415dcf0986
93%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Changes

Coverage Regressions

Jobs

Source Files on build ad2bc1ca-de45-4828-8b65-27415dcf0986

pulibrary / tigerdata-app / ad2bc1ca-de45-4828-8b65-27415dcf0986 93% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Changes

Coverage Regressions

Jobs

Source Files on build ad2bc1ca-de45-4828-8b65-27415dcf0986

pulibrary / tigerdata-app / ad2bc1ca-de45-4828-8b65-27415dcf0986
93%
main: 93%

README BADGES
x