umputun / ralphex / 33545264207

86%

push

github

fix: return repo-relative paths with forward slashes so the plan file excludes itself on Windows (#454)

* fix: return repo-relative paths with forward slashes

toRelative ran the path through filepath.Clean/filepath.Rel and returned the
result as-is, so on windows it yielded "docs\plans\feature.md" while git
reports "docs/plans/feature.md" everywhere. hasChangesOtherThan compares its
toRelative result against the paths from git status --porcelain, so the plan
file could never exclude itself once it lived in a subdirectory - and
plans_dir defaults to docs/plans.

Effect: --worktree aborts on windows with a self-contradicting message,
listing the plan file as the sole "uncommitted change other than the plan
file". Committing the plan first is the only workaround.

Convert both return paths with filepath.ToSlash. Every other caller (add,
moveFile, commitFiles, fileHasChanges) passes the result to git, which accepts
forward slashes on all platforms, so the conversion is safe there too.

Tests: the existing toRelative and hasChangesOtherThan cases already fail on
windows and pass again with the fix; added an explicit case for os-specific
separators. Two adjustments were needed to make the suite meaningful on
windows: the absolute-path expectation now compares against forward slashes,
and the outside-repo case uses t.TempDir instead of a unix-only literal, which
filepath.IsAbs rejects on windows so the case never reached the check.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test: compare git output against forward-slash paths

MovePlanToCompleted's assertions built their expectations with filepath.Join
and matched them against the output of git show --name-status and git ls-tree.
Those paths come from git, which prints forward slashes on every platform, so
the two cases failed on windows before and after the toRelative fix - the
expectation side was wrong, not the code under test.

Co-Authored-By: Claude Opus 5 (1M context) <nor... (continued)

2 of 2 new or added lines in 1 file covered. (100.0%)

8180 of 9519 relevant lines covered (85.93%)

224.03 hits per line