scikit-hep / iminuit / 33541395468

100%

push

github

fix: mask handling in BinnedCost._n_err and LeastSquares._pulls (#1145)

:robot: _AI text below_ :robot:

Two bugs in the pull computation, split out of #1137.

- An index-array mask was negated with `~`, which is bitwise NOT for
integers, so the wrong bins became NaN. The new helper
`_exclusion_from_mask` handles boolean masks and index masks.
- The user mask replaced the `err == 0` mask instead of combining with
it, so bins with zero error gave ±inf pulls instead of NaN.
`LeastSquares.pulls` now also gives NaN for zero-error points when no
mask is set (before: ±inf), consistent with `BinnedCost`. The `pulls`
docstring now states this.

Reported in #1132.

13 of 13 new or added lines in 1 file covered. (100.0%)

3907 of 3922 relevant lines covered (99.62%)

1.0 hits per line