supabase / auth / 33522957723
71%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 205
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.254%. Remained the same
33522957723

push

github

web-flow 
chore: add lefthook pre-commit hooks (#2768)

I noticed that we didn't have any pre-commit hooks setup, so proposing
that we add some.

I chose `lefthook` because it runs whatever command you give it without
pinning its own tool versions, which gives us a nicer way to use shared
targets.

## What kind of change does this PR introduce?
Chore

## What is the current behavior?
CI runs the linting checks. Contributors find their mistakes only after
they push a branch. The `gofmt` check lives inline in `test.yml` rather
than in a Make target, and the output instructs users to use a different
command than the one run, so nothing keeps a local check and the CI
check in sync.

## What is the new behavior?
- Added an optional `lefthook` configuration. 
- Add a `hooks` make target. It activates the hooks + builds the lint
tools.
- Added a `lint` make target to hold all of the static analysis checks,
and had `release-test` and `left hook` reference it so they share one
list.
- Added a `check-format` make target to replace the inline `gofmt` step
in `.github/workflows/test.yaml`

The hooks are optional. `CONTRIBUTING.md` has installation steps.

## Additional context
A couple notes:
- CI gets slightly stricter. The old inline `gofmt` step ran `gofmt -l`,
but its own error message said to run `gofmt -s -w` and `make format`
has always applied `-s` ([simplify](https://pkg.go.dev/cmd/gofmt)). So,
biasing in that direction seemed best. There are no changes today.
- These might be slow at first, but we can tune, and they're optional
 
Closes AUTH-1573

16233 of 22782 relevant lines covered (71.25%)

482.48 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33522957723.1 205
71.25
 GitHub Action Run
Source Files on build 33522957723