IntelPython / dpnp / 33499401606

78%

Build Type

push

github

Committed by web-flow

Commit Message

Fix sycl::queue leak in usm_ndarray `get_queue()`/`get_device()` (#3042)

This PR fixes a memory leak in the C++ accessors
`usm_ndarray::get_queue()` and `get_device()` in
`dpnp/include/dpnp4pybind11.hpp`

`UsmNDArray_GetQueueRef_` (dpnp's `usm_ndarray.get_queue_ref()`) returns
an owning copy of the queue (it calls `DPCTLQueue_Copy` i.e. new
`sycl::queue`)
Both accessors dereferenced this pointer and copied the queue out but
never freed the heap copy, leaking one `sycl::queue` per call. Under
queue churn this keeps `queue_impl` alive and prevents reuse of the
associated Level Zero command lists / event pools.

The fix adds `UsmNDArray_RemoveQueueRef` C-API to `dpnp_capi` (it binds
`DPCTLQueue_Delete`); `get_queue()/get_device()` take ownership of the
returned copy with `std::unique_ptr<sycl::queue>` whose custom deleter
frees it via `UsmNDArray_RemoveQueueRef`. This keeps allocation and
deallocation on dpctl's side of the ABI.

dpctl needs no change because its `Memory_GetQueueRef` returns a
borrowed ref, whereas dpnp's `UsmNDArray_GetQueueRef` is documented to
return a copy so it must be deleted.

Coverage Stats

1546 of 2898 branches covered (53.35%)

Branch coverage included in aggregate %.

13 of 22 new or added lines in 2 files covered. (59.09%)

1 existing line in 1 file now uncovered.

26627 of 32996 relevant lines covered (80.7%)

8641.27 hits per line