33466651246
38%

Ran 01 Sep 2026 05:18AM UTC

Jobs 1

Files 3101

Run time 4min

Badge

Embed ▾

Committed 01 Sep 2026 03:33AM UTC coverage: 23.689% (+0.1%) from 23.563%

Build # 33466651246

Build Type

push

github

Committed by

jcelerier

Commit Message

tests: a latched-out exit reports that closing may proceed

RegressionDoubleExitTest asserted that a second Presenter::exit() returns false,
and its header documented that as the contract: "any further call while exiting
(or after a completed exit) is a no-op returning false".

That return is also what View::closeEvent turns into accept/ignore:

    if(m_presenter->exit()) ev->accept(); else ev->ignore();

and since Qt 6.6 QCoreApplication::quit() closes the top-level windows and
honours the refusal. So false made the latch veto the very quit that
forceExit() had just scheduled, and no windowed instance could be shut down over
OSC /exit -- the defect fixed in fe3fd08a64, which changed exit() to answer true
and left this test asserting the behaviour it had just removed. Master has been
red since that merge; I opened it without running this test.

The property the test is named for is unchanged and still asserted: a second
request is a no-op that does not re-enter closeAllDocuments. Only the answer it
gives the caller changes, from "refuse the close" to "closing may proceed".

Negative-controlled: with `== false` restored, 2 of 4 assertions fail; with
`== true`, 4/4 pass.

Coverage Stats

53523 of 225936 relevant lines covered (23.69%)

62475.92 hits per line

Coverage Regressions

Lines	Coverage	∆	File
181	3.37	-0.37%	src/plugins/score-plugin-js/JS/Qml/EditContext.scenario.cpp
127	0.0	0.0%	src/plugins/score-plugin-js/JS/Qml/EditContext.port.cpp
89	7.14	7.14%	src/plugins/score-plugin-media/Video/GpuFormats.hpp
89	54.1	48.4%	src/plugins/score-plugin-media/Video/VideoDecoder.cpp
39	23.72	0.61%	src/plugins/score-plugin-js/JS/Qml/EditContext.device.cpp
30	78.88	0.71%	src/plugins/score-plugin-js/JS/ApplicationPlugin.cpp
28	42.24	-1.28%	src/plugins/score-plugin-gfx/Gfx/Settings/Model.cpp
3	94.12	-3.53%	src/plugins/score-plugin-media/Media/AudioPluginCache.hpp
2	96.67	0.0%	src/lib/core/presenter/Presenter.cpp
1	53.05	-0.27%	src/plugins/score-plugin-media/Media/Sound/WaveformComputer.cpp

Jobs

ID	Job ID	Ran	Files	Coverage
1	33466651246.1	01 Sep 2026 05:17AM UTC	3101	23.69	GitHub Action Run

ossia / score / 33466651246
38%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 33466651246

ossia / score / 33466651246 38%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 33466651246

ossia / score / 33466651246
38%

README BADGES
x