CyclopsMC / CyclopsCore / 33469962372

27%

master-1.21: 31%

Pull #236

github

Make the scrolling container reach the last row of a multi-column grid

ScrollingInventoryContainer supports multiple columns, but two places assume
there is only one.

ContainerScreenScrolling computes the scrollbar's total rows as
`filteredItemCount / getColumns()`, which truncates. With one column that is
exact, but with nine columns and 985 elements it gives 109 rows instead of 110,
so the four elements of the last row can never be scrolled to. The division is
rounded up now, in one place both call sites share.

isElementVisible guards against getPageSize(), which is the number of rows, and
so returns false for every element past the first row of a grid, even though
getVisibleElement returns them and onScroll fills them in. It now guards against
the size of the visible elements, which is rows times columns; for a
single-column container the two are the same.

The constructor also only null-filled the first getPageSize() entries of a list
that is rows times columns long. That was harmless, as the array it wraps is
already all-null, but it read as if the rest were left uninitialized.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T9xTc8kXNRDppvXktL24aR

1277 of 5176 branches covered (24.67%)

Branch coverage included in aggregate %.

3637 of 13269 relevant lines covered (27.41%)

1.32 hits per line