agronholm / anyio / 33453712302

91%

push

github

Shield TemporaryDirectory cleanup from cancellation (#1304)

TemporaryDirectory.__aexit__ ran the synchronous cleanup via to_thread.run_sync, which performs a cancellation checkpoint on entry. If the host task was already cancelled when exiting the context manager, that checkpoint aborted the cleanup before the worker thread was even dispatched, leaking the temporary directory.

Wrap the call in a shielded CancelScope so that a pending cancellation does not prevent the cleanup from running, and add a regression test verifying that the directory is removed when cancellation is requested while exiting the context manager.

3 of 3 new or added lines in 1 file covered. (100.0%)

6781 of 7421 relevant lines covered (91.38%)

11.65 hits per line