visgl / deck.gl / 33448350915

82%

push

github

fix(extensions): align billboard, 3D, justified, and offset dashes (#10580)

* test(extensions): add dash rendering baseline matrix for PathStyleExtension

Adds a render-test matrix and an interactive app for PathStyleExtension dashing,
covering segment density, dash arrays, corners, zoom levels, device pixel ratio,
3D elevation and billboard/flat parity.

The golden images record current behavior, defects included, so that subsequent
work shows up as a direct image diff. Measured from these goldens with
getDashArray [4, 5]:

- Six strips drawing the identical straight line diverge purely by vertex count.
  1, 2 and 4 segments dash correctly at a 43.4px period, 12 segments drifts to
  55.4px, and 40 and 120 segments render fully solid. Dash phase restarts at
  every vertex, so once a segment is shorter than one dash period nothing is
  discarded.
- dashJustified collapses the same way; justification is also per segment.
- highPrecisionDash renders all six strips identically and correctly, confirming
  the continuous-arclength mechanism works and is merely opt-in.
- billboard: true combined with highPrecisionDash is broken: the same geometry
  renders solid when dense and at a 52.0px period, 1.5x too long, when sparse,
  against 34.8px for the flat copy.
- Dash length grows along paths that climb in Z, because the CPU accumulates 3D
  distance while the shader coordinate measures 2D.

No source changes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014GipN1niYRgRuLVat2wujw

* test: recreate dash layers when dashMode changes

* test(extensions): add default dash path variants

* test(extensions): isolate 3D dash arclength

* test(extensions): cover pitched rounded billboard dashes

* test(extensions): separate path variant fixtures

* test(extensions): capture continuous offset dash baseline

* fix(extensions): make dashes match between billboard and flat paths

Dashing measured its along-path coor... (continued)

8645 of 11034 branches covered (78.35%)

Branch coverage included in aggregate %.

109 of 120 new or added lines in 3 files covered. (90.83%)

15018 of 17712 relevant lines covered (84.79%)

18288.89 hits per line