IntelPython / dpnp / 33437278403

78%

Build Type

push

github

Committed by web-flow

Commit Message

Fix dpnp.insert ignoring out-of-bounds negative indices in multi-element obj (#3041)

`dpnp.insert` has two index paths: the singleton path
(`_insert_singleton_index`) already validated bounds, but the
multi-element array path (`_insert_array_indices`) normalized negative
indices with `indices[indices < 0] += n` without any bounds check. As a
result, an out-of-bounds negative index mixed with in-bounds ones — e.g.
`dpnp.insert([0, 1, 2], [-6, 0], [9, 8])` — silently produced a wrong
result instead of raising.

This PR adds the same bounds validation NumPy introduced: if any index
is `< -n` or `> n`, `IndexError` is raised with the standard `index {i}
is out of bounds for axis {axis} with size {n}` message. In-bounds and
out-of-bounds indices mixed in a single call now consistently raise.

Coverage Stats

1546 of 2898 branches covered (53.35%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

26617 of 32978 relevant lines covered (80.71%)

8465.3 hits per line