GrottoCenter / grottocenter-api / 33429217503

91%

Build Type

push

github

Committed by ClemRz

Commit Message

fix(organizations): treat isPermanent=false/0 as a soft delete

Addresses Paul's review feedback on the explored-caves merge fix.

- Parse isPermanent with [true, 'true', '1'].includes(...) instead of
  !!req.param(...): query params arrive as strings, so both ?isPermanent=false
  and the web client's ?isPermanent=0 encoding were truthy and irreversibly
  hard-deleted the organization. Matches guideline/delete.js
- Add regression coverage for the false and 0 encodings, asserting the row
  survives in the database. Checking res.body.isDeleted alone is not enough:
  the soft-delete pass sets that flag before the permanent branch would run,
  so the response looks identical either way
- Install the histo_delete_grotto trigger in the test schema, mirroring
  sql/0_triggers.sql. Without it TGrotto.destroyOne() hard-deletes in tests
  and the survives-in-database assertion cannot be made at all
- Add test/seed-database.js to SNAPSHOT_SOURCES: customSQL.js only defines
  the SQL blocks, the seed file decides which ones run, so editing it changed
  template state without invalidating the staleness stamp

Coverage Stats

5209 of 6259 branches covered (83.22%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

10 existing lines in 2 files now uncovered.

9573 of 10672 relevant lines covered (89.7%)

142.0 hits per line