solidjs / solid / 33416323909

72%

main: 89%

push

github

fix: latest()-mode isPending probes are read-order dependent (#3104)

Two probe-mode leaks in the verdict layer. latestRead's mid-tick shadow
pull (#2922) recomputed a stale shadow with the probe still live, so the
shadow's own read(parent) collected the parent into the probe — the
verdict flipped to the held-write answer only when nothing had pulled
the shadow current earlier in the tick (reading latest(m) before
latest(() => isPending(x)) changed the answer from true to false). And
collectPending's companion-verdict reads ran with an outer latest()
window still active, dispatching through latestRead and building a
shadow OF THE PENDING SIGNAL itself; the next flush's
updatePendingSignal wrote that companion-on-companion from inside a
recompute and halted dev with the owned-scope write guard. Both sites
now suspend the ambient read modes like the companion creation paths
always did.

Co-authored-by: Cursor <cursoragent@cursor.com>

517 of 789 branches covered (65.53%)

Branch coverage included in aggregate %.

767 of 1003 relevant lines covered (76.47%)

14.54 hits per line