openvax / topiary / 33414565154

91%

master: 93%

Build Type

Pull #215

github

Committed by iskandr

Commit Message

Add default_versions to resolve an ambiguous predictor version (#214)

default_methods answers "which model, when a kind has several". Nothing
answered "which version, when a model has several", so an unqualified
reference on a multi-version frame raised with no configured way through
and a consumer's default scoring expression could not run at all.

This gap was ours, and our own fix made it reachable. 5.28.2 added the
version-ambiguity raise so two versions could no longer resolve silently
to whichever row came first -- correct, but shipped without the way
through, in the same release series whose notes described the identical
problem one level up as "a working configuration turned into a hard
error". Keeping both versions of a multi-version LENS table (#208) is
what made a frame like that reachable in the first place.

default_versions is keyed on (kind, model) since a version means nothing
without its model, and is forwarded by apply_filter/apply_sort/
evaluate_scores like the other context options.
resolve_default_versions(df, prefer="newest") orders by PEP 440 -- the
only ordering where 4.10 beats 4.9 -- and sorts non-PEP-440 versions
before everything that parses, so "newest" means a real release rather
than whichever string sorted last.

packaging becomes a declared dependency. It was already there
transitively, but the ordering depends on it and catching ImportError
alongside InvalidVersion would have quietly demoted every version to
string order.

26 tests. Version 5.31.0.

Claude-Session: https://claude.ai/code/session_01BAUqjqDDPXaTdtUDJqapJG

Pull Request Pull Request #215: Add default_versions to resolve an ambiguous predictor version (#214)

Coverage Stats

75 of 84 new or added lines in 2 files covered. (89.29%)

108 existing lines in 1 file now uncovered.

5719 of 6278 relevant lines covered (91.1%)

2.73 hits per line