opendefensecloud / solution-arsenal / 33403581842
80%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 89
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.177% (-0.06%) from 80.235%
33403581842

push

github

web-flow 
refactor: use envtest sideloading from dev-kit (#782)

## What

Replace this repository's copy of the envtest sideload script with the
shared `envtest-binaries-sideload` target from dev-kit v2.1.0.

Refs opendefensecloud/odd-internal#59

## Why

`setup-envtest`'s release index lags upstream Kubernetes, so bumping
`ENVTEST_K8S_VERSION` to a fresh release breaks `make test` until
controller-tools catches up (#556). The workaround was landed
independently in three repositories and then diverged — this one held
the only copy with macOS support, etcd `.zip` handling, and the `shasum`
fallback. dev-kit v2.1.0 hoists exactly this copy, so the other two
repositories inherit the fixes and this one stops being the sole
maintainer of shared code.

## Testing

- `make envtest-binaries-sideload` cold — fetched the script to
`bin/envtest-sideload-v2.1.0.sh`, sideloaded K8s 1.36.1 with etcd 3.6.8,
checksums verified.
- Re-run warm, and again with the network blackholed
(`HTTPS_PROXY=http://127.0.0.1:1`) — exit 0, confirming `make test`
keeps no hard network dependency once the cache is warm.
- `shellcheck` over the remaining tracked shell scripts — clean.
- `make test` — full suite green.
- macOS, against the dev-kit branch before tagging: `git`/`unzip`
resolve from the dev shell, the source-build path produced a working
`kube-apiserver v1.36.1`, and the etcd `.zip` plus `shasum -a 256`
fallback both exercised.

## Notes for reviewers

The `flake.nix` input moves from `dev-kit/v2.0.0` to `v2.1.0`, which is
what adds `git` and `unzip` to the dev shell. Both are required on
macOS: `dl.k8s.io` publishes no darwin `kube-apiserver`, so the script
shallow-clones Kubernetes and builds it, and etcd ships `.zip` rather
than `.tar.gz` there. Go is not supplied by dev-kit's own shell — it
comes from this repository's `goVersion`.

The `ENVTEST_K8S_VERSION ?= 1.36.1` pin deliberately stays in this
Makefile rather than moving to `common.mk`: Renovate's shared `k8s`
preset matche... (continued)

5517 of 6881 relevant lines covered (80.18%)

34.78 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
74.81
 -1.53% pkg/controller/component_controller.go
2
73.13
 -2.99% pkg/controller/registrybinding_controller.go
2
88.1
 -0.38% pkg/controller/rendertask_controller.go
Jobs
ID Job ID Ran Files Coverage
1 33403581842.1 89
80.18
 GitHub Action Run
Source Files on build 33403581842