UI5 / cli / 33404730823

94%

Build Type

push

github

Committed by web-flow

Commit Message

feat!: Replace HTTP/2 support with HTTPS (#1532)

Remove the `--h2` option of `ui5 serve` and the underlying HTTP/2
infrastructure, and add a new `--https` option in its place.

HTTP/2 was served via the `spdy` package, which is unmaintained and does
not work with Node.js v24 and higher. The new `--https` option uses
Node.js' built-in `https` server instead. The existing SSL certificate
handling (auto-generation, `--key`/`--cert`) is reused.

The HTTPS test disabled certificate validation via
NODE_TLS_REJECT_UNAUTHORIZED=0.
Replace this with proper trust of the server certificate via
superagent's .ca() on the test agent, applied once so all requests
inherit it.
The previous fixture server.crt was a leaf certificate signed by a
separate, uncommitted CA, so it could not act as its own trust anchor.
Regenerate it as a genuine self-signed certificate for localhost.

JIRA: CPOUI5FOUNDATION-1310
JIRA: CPOUI5FOUNDATION-1311
See: https://github.com/UI5/cli/issues/327
Closes: https://github.com/UI5/cli/pull/1131

BREAKING CHANGE: The `--h2` option of `ui5 serve` has been removed. Use
`--https` to serve the project over HTTPS. The `@ui5/server` `serve()`
option `h2` and the returned `h2` property have been renamed to `https`.
If you need HTTP/2 for local development, put a reverse proxy (e.g.
nginx) in front of the server to terminate it.

---------

Co-authored-by: Günter Klatt <guenter.klatt@sap.com>

Coverage Stats

7293 of 8041 branches covered (90.7%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 3 files covered. (100.0%)

2 existing lines in 2 files now uncovered.

13963 of 14563 relevant lines covered (95.88%)

5260.81 hits per line