nephila / python-taiga / 33383913108

98%

master: 98%

Pull #268

github

fix(mcp): close pagination bypass, stop serializing stale patch/comment state

Address 4 review comments on PR #268 (commit cb66914):

- _paginated(): filters was forwarded straight into ListResource.list(),
  so pagination=False (a client-control kwarg) or an explicit but falsy
  page/page_size (None, 0) bypassed the page-1/page_size-100 bound and
  could trigger an unbounded full-collection fetch. Strip `pagination`
  and normalize falsy page/page_size instead of dict.setdefault().

- update_*/update_*_by_id (9 call sites) and update_wiki_page:
  InstanceResource.patch() only refreshes `version` on the local object,
  not the fields the server actually applied - serializing the patched
  object directly returned stale pre-update values. Re-fetch the
  resource after patching before serializing it.

- add_comment/add_comment_by_id: CommentableResource.add_comment()
  delegates to update(), which has the same staleness issue and never
  carries the comment itself (comments are history entries, not a
  resource field). Return an explicit {"status": "commented", ...}
  acknowledgement instead of serializing the stale resource.

Updated tests/test_mcp_server.py for all of the above.

161 of 180 branches covered (89.44%)

1249 of 1271 relevant lines covered (98.27%)

3.93 hits per line