solidjs / solid / 33364909506

72%

main: 89%

push

github

fix(web): import the types the server-functions declarations reference (#3103)

* fix(web): import the types the server-functions declarations reference

client.ts and server.ts only re-exported ServerFunction and
ServerFunctionMetadata (export type { ... } from), which creates no local
binding, while GET/live/createServerReference and several interfaces
reference them in annotations. With @ts-nocheck in both files nothing
flagged the dangling names, so declaration emit shipped them unresolved
and skipLibCheck turned every server function reference into a silent
any for consumers (a GET-wrapped queryFn typed its data as any).

* fix(web): the client live() reference returns its iterable synchronously — type it that way

live(fn)(...) hands back the reconnecting iterable itself (the transport
connects lazily on the first pull); only the server half's in-process
call is async. The old declaration routed through ServerFunction, whose
call signature promises Promise<T> — a mismatch invisible while the
dangling declaration references this PR fixes kept the whole chain
collapsed to any, and a type error the moment they resolve (the web
test-types failure on this PR's CI). Isomorphic consumers still await
the call; awaiting the client's plain iterable is identity.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

517 of 789 branches covered (65.53%)

Branch coverage included in aggregate %.

767 of 1003 relevant lines covered (76.47%)

14.53 hits per line