supabase / supavisor / 33363417291
78%

DEFAULT BRANCH: main
Ran
Jobs 2
Files 132
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.03% (+0.1%) from 77.924%
33363417291

push

github

web-flow 
fix: remove dead cache invalidation in SecretChecker.do_update_credentials (#1151)

## What

`SecretChecker.do_update_credentials/1` (the manager/auth_query
credential hot-swap handler) had:

```elixir
# Clear the secrets cache for this tenant/user
Cachex.del(Supavisor.Cache, {:secrets, state.tenant, state.user})
```

`{:secrets, tenant, user}` is never written anywhere in the codebase —
the real validation-secrets cache is keyed `{:secrets_for_validation,
tenant, user}`. So this call was a no-op.

## Why not just fix the key

Even corrected to `{:secrets_for_validation, ...}`, invalidating
`state.user`'s (the pooled role's) validation secret here wouldn't be
meaningful: this handler only rotates the manager/auth_query service
account's own login credentials, used to run the query that fetches
other roles' secrets. That rotation has no bearing on whether
`state.user`'s own SCRAM verifier is stale — the two secrets are
unrelated.
Found while investigating SU-447169 /
[POOLER-689](https://linear.app/supabase/issue/POOLER-689).

## Verification

- `grep -rn "{:secrets," lib/` confirms zero other readers/writers of
the old key.
- No existing tests reference
`:update_credentials`/`do_update_credentials`, so nothing asserts on the
removed call.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

2788 of 3573 relevant lines covered (78.03%)

52308.06 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
76.92
 -7.69% lib/supavisor/erl_sys_mon.ex
Jobs
ID Job ID Ran Files Coverage
1 run-tests - 33363417291.1 132
76.63
 GitHub Action Run
2 run-integration - 33363417291.2 132
42.35
 GitHub Action Run
Source Files on build 33363417291