umputun / remark42 / 33344808642

85%

master: 85%

Build Type

Pull #2240

github

Committed by paskal

Commit Message

Cover in the browser what jest was covering alone, and drop those cases

The previous change removed the jest cases the browser suite already asserted.
These are the ones it could have asserted and did not: the states behind a
held-open request, the actions an ordinary reader is offered, an order nothing
read, and the values inside elements the suite only waited for.

Eighteen jest cases go. Each is released by a named browser assertion, and each
of those is proven by a mutant that makes it fail at the assertion it names,
recorded in the pull request with the mutant and the expected failure point. Line
coverage is not the check here: two cases can run identical lines and assert
different things.

That discipline caught four assertions of mine that proved nothing. Delete
being absent on another reader's comment held with the ownership test removed,
because editDeadline is supplied only for the reader's own comment and the
weaker condition is equivalent. Reply being absent on a read-only thread held
because the thread had no comments in it. The profile states passed with the
route glob never matching, since a question mark is a single-character wildcard
in playwright's url matching. And a cast downvote staying disabled held with
its guard removed, because the in-flight guard covers it either way; that one
could not be fixed, so the assertion was withdrawn and its jest case kept.

Where one of those traps can be tripped again, the warning sits beside the code
that would trip it: the read-only case says why it posts a comment first, the
profile case says why its route is a regexp, the countdown says why its bound
allows a second, and the downvote case says why the assertion that looks like
it belongs there is not there.

The counter gets a class outside the css modules. It carried only a hashed name
and a data-testid the production bundle strips, which is what kept the count
out of reach of a browser case.

Pull Request Pull Request #2240: Cover in the browser what jest was covering alone, and drop those cases

Coverage Stats

72 of 91 new or added lines in 2 files covered. (79.12%)

1 existing line in 1 file now uncovered.

6714 of 7863 relevant lines covered (85.39%)

38.15 hits per line