binbashar / leverage / 33335308766

65%

master: 61%

Pull #323

github

Fix | Do not require a terminal to run the bats tests

The suite ran under `docker run -t`, which allocated a TTY, so it could take
one for granted. On the runner there is none, and `$TERM` is unset:

  tput: No value for $TERM and no -T specified
  validator.bash: line 8: printf: write error: Broken pipe

Two things assumed a terminal. `setup_file` printed a header through `tput`,
which fails outright without `$TERM`, and the make target forced the pretty
formatter, which needs one. `-t` and `-p` were both passed, which is
contradictory since either sets the formatter, and the pretty one won.

The header no longer goes through `tput`, and no formatter is forced, so bats
picks the pretty one on a terminal and tap when there is none.

Verified both ways, with `$TERM` set and unset: 10 tests pass, `make test-int`
exits 0, and no tput or broken pipe errors in either.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

514 of 1024 branches covered (50.2%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

2778 of 4014 relevant lines covered (69.21%)

0.69 hits per line