CyclopsMC / IntegratedDynamics / 33329696473

46%

master-1.21-lts: 47%

Pull #1709

github

Clean up the cables that the append benchmarks add outside the network cube

GameTestsPerformance#addCablesPostWarmup appends its cables just outside of
the generated network cube, up to 100 blocks above it, while the cleanup after
each measurement only clears the cube itself.

Those cables were therefore never removed, so their network stayed alive for
the remainder of the server run and kept being ticked while the tests that run
afterwards were being measured, and it was persisted into the world save.

Measured over a full run, this removes the two leftover networks of about 90
cables each that the append tests left behind (331 -> 329 persisted networks,
and a 17% smaller network storage file, since those two are by far the largest
ones). Note that a full run leaves several hundred smaller networks behind in
total, so this does not by itself make repeated runs over the same world
comparable.

The appended cables are now cleared together with the cube. A bounding box
variant of NetworkGenerationHelper#clearCables is added for that, so that the
SKIP_NETWORK_INIT handling stays in one place.

2818 of 8956 branches covered (31.46%)

Branch coverage included in aggregate %.

12338 of 24321 relevant lines covered (50.73%)

2.42 hits per line