tselect-npm / url / 33311016533

100%

push

github

:bug: Eliminate polynomial ReDoS in ensureTrailingSlash (#25)

* fix: eliminate polynomial ReDoS in ensureTrailingSlash

Replace the /\/+$/ regex with a linear charCodeAt scan. The anchored
quantifier backtracked quadratically on inputs of many '/' not followed
by end of string (measured 5.3s at 80k chars; now ~0.01ms). Adds
regression tests for long slash runs and adversarial input; coverage
stays at 100%.

Fixes #22

* :lipstick: Use constant for forward slash character code

Replaced hardcoded character code for forward slash with a constant.

---------

Co-authored-by: painbaba <painpratham@gmail.com>
Co-authored-by: Sylvain Estevez <estevez.sylvain@gmail.com>

27 of 27 branches covered (100.0%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

37 of 37 relevant lines covered (100.0%)

276.3 hits per line