umputun / remark42 / 33306932798
85%
master: 85%

LAST BUILD BRANCH: e2e-covers-more
DEFAULT BRANCH: master
Ran
Jobs 1
Files 54
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.427%. Remained the same
33306932798

Pull #2238

github

paskal 
Whitelist the docker build context, and ignore worktrees

Previously .dockerignore listed what to keep out, so whatever appeared at
the repo root next rode along uninvited: a .worktrees directory reached
362MB before anyone noticed it was being uploaded on every build, and
site/, docs/, .github/, screenshots/ and jest coverage output were going
along with it.

After this change the file excludes everything and restores only the three
paths the images actually build from: backend, which the main image builds
./app from and the memory_store example image builds its own binary from,
frontend/apps/remark42 for the widget, and docker-init.sh for the
entrypoint. Anything new at the root now stays out by default.

The committed backend/app/cmd/web/index.html keeps an explicit exception,
because a SKIP_FRONTEND_BUILD image has nothing else to satisfy the
go:embed in server.go with.

Measured on a clean checkout with a probe image that copies the context and
counts it: 2937 files and 37MB before, 2826 files and 35MB after. The saving is
small because a fresh tree carries none of the residue that prompted this; the
point is that whatever lands at the root next is excluded until someone says
otherwise, which is what the blacklist could not do.

The full e2e suite passes against an image built this way, and the memory_store
example image, which builds from this same context, still builds.
Pull Request #2238: Whitelist the docker build context, and ignore worktrees

6665 of 7802 relevant lines covered (85.43%)

38.26 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33306932798.1 54
85.43
 GitHub Action Run
Source Files on build 33306932798