solidjs / solid / 33303945847

72%

main: 89%

push

github

test(web): mark three open server-function gaps as expected failures (#3112)

* test(web): mark three open server-function gaps as expected failures

Each is verified against `next` and stated as the behaviour that is
wanted, so the suite stays green while the gap is open and turns red the
day it closes.

- A result the codec cannot encode is delivered as `undefined`. The
  function already ran; only the encoding failed, and it failed after the
  head was committed, so the status is spent and no error tag can be
  added. The truncated body decodes to the same answer a void function
  gives, so a write that succeeded is indistinguishable from one that
  returned nothing.

- A streamed result has no backpressure: the stream is built with no
  `pull` and no queuing strategy, and every codec node is enqueued as
  soon as it is parsed. A consumer reading three chunks over 60ms left
  the producer 3695 items ahead; on a large or infinite stream one slow
  client buffers the whole result in server memory.

- The decode depth cap guards the seroval path only, and the body format
  is chosen by the caller, so selecting the JSON format opts out of it:
  depth 5000 decodes where the capped path answers 400.

`.fails` rather than the repo's `test.skip` idiom because the point is to
notice the fix. Tests only; no runtime change, so no changeset.

* test(web): fix the depth gap's header, and make two assertions honest

Review of the first commit turned up three things, one of which made a
test worthless:

- BODY_FORMAT_HEADER is not exported from the server entry, so the import
  was `undefined` and the request carried a header literally named
  "undefined". The JSON format was never selected and the function
  received no argument at all: the handler answered {"depth":0} where the
  gap needs {"depth":500}. The test failed, but not for its own reason —
  exactly the failure mode `.fails` cannot show you. Local const, as
  `server-functions-failure-signal.spec.tsx`... (continued)

517 of 789 branches covered (65.53%)

Branch coverage included in aggregate %.

767 of 1003 relevant lines covered (76.47%)

14.53 hits per line