CyclopsMC / IconExporter / 33295007802

7%

master-26-lts: 8%

Pull #41

github

Scale the icon pose uniformly so block icons keep their shading

Exported block icons came out about 30% darker than the same block looks
in the vanilla inventory, while flat (2D) item icons were fine.

renderGuiItem scaled the pose by (f, f, 1) to reach the requested icon
size, with f = (iconSize / guiScale) / 16. PoseStack#scale reacts to a
non-uniform scale by scaling the normal matrix by (1/f, 1/f, 1) and
marking the normals as untrusted, so every vertex normal gets its X and
Y components squashed. That flattens the diffuse part of Minecraft's GUI
lighting (the ambient part is unaffected), which costs 3D block models
most of their shading. Flat item sprites face the camera and are
unaffected, which is why only block icons looked wrong.

Scaling uniformly leaves the normal matrix alone: the resulting pose is
identical to the one vanilla's ItemRenderer#renderGuiItem builds, for any
icon size and GUI scale. renderFluid already scales uniformly.

Measured on the three visible faces of full-cube blocks, relative to the
block texture (vanilla renders these at 0.99 / 0.65 / 0.40):

  f = 1    0.975 / 0.634 / 0.396
  f = 2    0.687 / 0.466 / 0.391
  f = 4    0.566 / 0.418 / 0.397

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013FpcjAK5qKkXRQHQfwjWnz

2 of 64 branches covered (3.13%)

Branch coverage included in aggregate %.

26 of 331 relevant lines covered (7.85%)

0.31 hits per line