umputun / remark42 / 33286191832
85%
master: 85%

LAST BUILD BRANCH: e2e-covers-more
DEFAULT BRANCH: master
Ran
Jobs 1
Files 54
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.427%. Remained the same
33286191832

Pull #2234

github

paskal 
Report what the browser suite reaches in the widget

The backend half of this already exists; the widget had nothing. jest reports
what its own suites reach, which says nothing about the browser suite, so
every component the e2e cases drive counted as unmeasured.

The bundle is built with babel-plugin-istanbul behind the COVERAGE argument
the backend stage already reads, so one flag instruments both halves of the
stack and the existing overlay needs no change. The bundle counts on the page,
the suite reads the counters out, and nyc merges them and reports beside the
Go total. The suite reaches 75% of widget statements against jest's 60%.

The counters belong to the document, so a reload or a second navigation throws
them away: a snapshot is taken before each of those and again at cleanup, and
each is numbered so one page's snapshots do not overwrite each other. Read only
at the end, the suite reported six points lower and the loss was invisible,
since a test that acts and then reloads still produced a plausible figure.

Both the page and the iframe carry counters, since the embed script runs in the
one the test navigated and the widget in the frame below it, so every frame is
asked and a frame with no bundle is not an error.

The paths are the paths the bundle was built at, under /srv/frontend/apps/remark42,
which resolves nowhere on the host. The prefix comes off as the counters are
read and a path still absolute afterwards fails, because the reporter would
otherwise drop or misplace that file without tripping the empty-directory guard.

coverageGlobalScopeFunc is off because the default preamble reaches the global
object through new Function, and the widget document is served with script-src
'self' 'unsafe-inline'. The browser refuses it, the bundle throws before it
renders, and an instrumented stack then fails every browser test instead of
reporting anything.

Collection failures fail the test rather than being skipped, an empty directory
fails the... (continued)
Pull Request #2234: Report what the browser suite reaches in the widget

6665 of 7802 relevant lines covered (85.43%)

38.19 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33286191832.1 54
85.43
 GitHub Action Run
Source Files on build 33286191832