umputun / remark42 / 33285486692

85%

master: 85%

Build Type

Pull #2228

github

Committed by paskal

Commit Message

Drive Telegram authentication and subscriptions through the browser

Telegram is the one auth provider whose flow leaves the browser: the
reader messages a bot, and no page can reach that. e2e/telegramstub
answers as the bot API for the four calls the flow makes and takes the
reader's side of the exchange through /control/send, so the round trip
becomes drivable end to end. It runs on its own instance, because adding
a provider to the main one would change the auth panel every other case
reads.

Reaching it needs the bot API base url to be settable, which is what
--telegram.api-url adds. It serves a real operator need beyond the tests,
a proxy or a self-hosted Bot API server where Telegram is blocked, and
both consumers honour it: the auth provider and the notification service.
The value is an origin, and the token travels in the request path, so it
has to be a host the operator controls.

Writing the coverage found two defects in the wiring. An instance with
telegram auth enabled and notifications failing registered the provider
and never started anything to listen, so it accepted the configuration
and stayed permanently deaf. And a nil *notify.Telegram was assigned into
an interface, where it is not nil, so the guard downstream let it through.

The subscription panel needed three fixes of its own. Resubscribing set the
step back without requesting a new token, so the panel offered a link built
from one the backend had already discarded. A failure stayed on screen after
the next call succeeded, because neither the check nor the unsubscribe
cleared it. And the message had nowhere to render outside the initial step,
so a failure in the other two was silent.

The settable API base reaches the notification service through go-pkgz/notify
v1.5.0 and the auth provider through go-pkgz/auth v2.3.0, both released.

compose-e2e-coverage.yml gains the Telegram instance. coverage.sh takes the
services it must see a profile from, and the directories it merges, fro... (continued)

Pull Request Pull Request #2228: Drive Telegram authentication and subscriptions through the browser

Coverage Stats

72 of 91 new or added lines in 2 files covered. (79.12%)

1 existing line in 1 file now uncovered.

6714 of 7863 relevant lines covered (85.39%)

38.07 hits per line