archetech / archon / 33279087773

92%

main: 87%

Pull #963

github

fix(db): Correct the Node range node:sqlite actually needs

Review found the engines floor admits runtimes where the module does not
load. node:sqlite landed in 22.5.0 but stayed behind --experimental-sqlite
until 22.13.0 / 23.4.0, so `>=22.5.0` lets a consumer on 22.5-22.12 or
23.0-23.3 satisfy the range and then fail at import -- the exact failure
declaring engines was meant to replace with a clear npm error.

Also from review:

- The pinning guard only matched well-formed versions, so `FROM node:22`
  or `node-version: lts/*` vanished from the set rather than failing it,
  leaving the single-pin assertion green while the engine floated. It now
  collects every declared version and rejects any that is not exact.

- The wallet test still matched the driver's error text after claiming to
  assert behaviour. It now asserts that saving rejects and that the folder
  is absent, which is the actual guarantee.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

3881 of 4464 branches covered (86.94%)

Branch coverage included in aggregate %.

48 of 49 new or added lines in 2 files covered. (97.96%)

8528 of 8953 relevant lines covered (95.25%)

717.55 hits per line